dialog: Split out _setLabel function

This will be useful when adding more generic containers like
MessageDialogContent.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/935

diff --git a/js/ui/dialog.js b/js/ui/dialog.js
index dfa656230ffbdf33c2a00704337f394fadb13d7a..642873be659d817ece04284468698b46171ab1ba 100644 (file)
--- a/js/ui/dialog.js
+++ b/js/ui/dialog.js
@@ -3,6 +3,13 @@
 
 const { Clutter, GObject, Pango, St } = imports.gi;
 
+function _setLabel(label, value) {
+    label.set({
+        text: value || '',
+        visible: value !== null,
+    });
+}
+
 var Dialog = GObject.registerClass(
 class Dialog extends St.Widget {
     _init(parentActor, styleClass) {
@@ -185,18 +192,12 @@ var MessageDialogContent = GObject.registerClass({
     }
 
     set title(title) {
-        this._setLabel(this._title, 'title', title);
+        _setLabel(this._title, title);
+        this.notify('title');
     }
 
     set description(description) {
-        this._setLabel(this._description, 'description', description);
-    }
-
-    _setLabel(label, prop, value) {
-        label.set({
-            text: value || '',
-            visible: value != null,
-        });
-        this.notify(prop);
+        _setLabel(this._description, description);
+        this.notify('description');
     }
 });